Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On empty string, internal error: ValueId cannot be zero #1477

Closed
niemeyer opened this issue Sep 18, 2017 · 3 comments
Closed

On empty string, internal error: ValueId cannot be zero #1477

niemeyer opened this issue Sep 18, 2017 · 3 comments
Assignees
Labels
kind/bug Something is broken.
Milestone

Comments

@niemeyer
Copy link

niemeyer commented Sep 18, 2017

Hello again,

I'm getting an error while attempting to add an edge from Go which is set to an empty string:

rpc error: code = Unknown desc = failed to apply mutations error: internal error: ValueId cannot be zero

The code looks like the typical edge insertion, I believe:

edge = node.Edge("svalue")
err = edge.SetValueString(v)
if err == nil {
        req.Set(edge)
}
if err != nil {
        return err
}

Hacking the value to be non-empty in those specific cases with v = "-" makes the code work fine.

Setting empty strings via the browser also works fine.

@manishrjain manishrjain added the investigate Requires further investigation label Sep 18, 2017
@manishrjain manishrjain added this to the v0.8.2 milestone Sep 18, 2017
@pawanrawal pawanrawal added kind/bug Something is broken. and removed investigate Requires further investigation labels Sep 18, 2017
@pawanrawal
Copy link
Contributor

Thanks for reporting the issue @niemeyer. I have pushed a fix as part of cb8a79f and it would be part of the next release.

pawanrawal pushed a commit that referenced this issue Sep 18, 2017
@niemeyer
Copy link
Author

niemeyer commented Sep 18, 2017

Thanks for the quick fix @pawanrawal.

Reading the fix, do we have some special semantics by setting a string value with _nil_? What happens if that string happens to be found in the data itself?

@niemeyer
Copy link
Author

Yes, that's indeed true as confirmed with code. I'm opening a separate issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken.
Development

No branches or pull requests

3 participants