Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination is not applied as the last step by default #889

Closed
aaaton opened this issue Apr 27, 2017 · 2 comments
Closed

Pagination is not applied as the last step by default #889

aaaton opened this issue Apr 27, 2017 · 2 comments
Assignees
Labels
kind/bug Something is broken.
Milestone

Comments

@aaaton
Copy link

aaaton commented Apr 27, 2017

I have an issue with combining filtering, ordering and pagination. For a dataset where a person is connected to a number of events, where each event has a type and a timestamp I can do this:

{
  persons(id:person.1234) {
    person.event (first: 2) @filter(eq(event.type,"BIRTHDAY")) {
      event.title
    }
  } 
}

and get 2 results, but if I do this:

{
  persons(id:person.1234) {
    person.event (first: 2, orderdesc:event.timestamp) @filter(eq(event.type,"BIRTHDAY")) {
      event.title
    }
  } 
}

I receive 0 results. If I increase the first to 100, I get 2 results (which is all the dataset contains). It seems the filters, ordering and pagination are applied in the wrong order. What is the use case of pagination not being applied as the last step?

@manishrjain manishrjain added the kind/bug Something is broken. label Apr 27, 2017
@manishrjain manishrjain added this to the v0.7.4 milestone Apr 27, 2017
@pawanrawal
Copy link
Contributor

Thanks, for finding the issue. The fix has been merged to master and would be part of the upcoming release.

@aaaton
Copy link
Author

aaaton commented Apr 28, 2017

Wow! 18 hours from report to merge? Impressive.

@manishrjain manishrjain added the kind/bug Something is broken. label Mar 22, 2018
arijitAD pushed a commit that referenced this issue Oct 15, 2020
- update --node flag to --chain
- update NodeFlag to ChainFlag
- update node directory to chain directory
- update/revise comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something is broken.
Development

No branches or pull requests

3 participants