fix(GraphQL): Disallow Subscription typename.

[JatinDev543]

This PR disallow Subscription typename so that it doesn't conflict with Subscriptions generated.

---

This change is 

[pawanrawal]

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @jatindevdg and @MichaelJCompton)

---

graphql/schema/gqlschema_test.yml, line 2693 at r1 (raw file):

        owns: [Object] @dgraph(pred: "~Object.owner")
      }

Why add newlines here?

---

graphql/schema/rules.go, line 275 at r1 (raw file):

		"StringExactFilter":    true,
		"StringHashFilter":     true,
		"Subscription":         true,

Why is it forbidden as an input name as well? I thought we only forbid it as a typename.

---

graphql/schema/rules.go, line 1785 at r1 (raw file):

func isReservedKeyWord(name string) bool {
	if isScalar(name) || isQueryOrMutation(name) || isReserve(name) {

instead of creating a function called isReserve, just define the map here in this function and use it.

---

graphql/schema/schemagen_test.go, line 170 at r1 (raw file):

				_, authError := FromString(schHandler.GQLSchema())

Any reason to remove this newline?

[JatinDev543]

Reviewable status: 0 of 2 files reviewed, 4 unresolved discussions (waiting on @MichaelJCompton and @pawanrawal)

---

graphql/schema/gqlschema_test.yml, line 2693 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Why add newlines here?

By mistake, deleted now.

---

graphql/schema/rules.go, line 275 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Why is it forbidden as an input name as well? I thought we only forbid it as a typename.

yeah not required, i checked and deleted it.

---

graphql/schema/rules.go, line 1785 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

instead of creating a function called isReserve, just define the map here in this function and use it.

changed it.

---

graphql/schema/schemagen_test.go, line 170 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Any reason to remove this newline?

This is also by mistake, deleted now .

[pawanrawal]

Reviewed 3 of 3 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MichaelJCompton and @pawanrawal)