fix(GraphQL): fix exclusion of filters in Query generation in case of… #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… just Has Filters. (#6870) Fixes GRAPHQL-787. This PR fixes the Bug in query and mutations generation in case of types that have just `has` filter and not any other kind of filter. For example for the given type: ``` type Student { name: String age: Int } ``` the corresponding query generated was ``` queryStudent(order: StudentOrder, first: Int, offset: Int): [Student] ``` and only `add` mutation was being generated. Whereas, the correct query should be: ``` queryStudent(filter: StudentFilter, order: StudentOrder, first: Int, offset: Int): [Student] ``` and corresponding update and delete mutation should be: ``` updateStudent(input: UpdateStudentInput!): UpdateStudentPayload deleteStudent(filter: StudentFilter!): DeleteStudentPayload ``` (cherry picked from commit 5e60ef1)
minhaj-shakeel
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
reviewed
Nov 19, 2020
pawanrawal
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… just Has Filters. (#6870)
Fixes GRAPHQL-787.
This PR fixes the Bug in query and mutations generation in case of types that have just
hasfilter and not any other kind of filter. For example for the given type:the corresponding query generated was
and only
addmutation was being generated.Whereas, the correct query should be:
and corresponding update and delete mutation should be:
(cherry picked from commit 5e60ef1)
This change is