Fix(GraphQL): Fix bug with password query rewriting #7011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
|
Deploy preview for dgraph-docs ready! Built with commit 5c8e4b9 |
pawanrawal
approved these changes
Nov 27, 2020
vmrajas
added a commit
that referenced
this pull request
Nov 27, 2020
* Fix bug with password query rewriting * Remove query.ResponseName() from query_rewriter.go (cherry picked from commit 46a39c6)
vmrajas
added a commit
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Related Discuss post: https://discuss.dgraph.io/t/panics-on-checkpassword-with-alias/11629
Testing:
Added e2e test and a test to query_test.yaml
Fixes GRAPHQL-884
This change is