[BREAKING] opt(raftwal): store only membership state to disk in the zero snapshot #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
changed the title
NamanJain8
changed the title
|
✔️ Deploy preview for dgraph-docs ready! 🔨 Explore the source changes: 5ba4c21 🔍 Inspect the deploy logs: https://app.netlify.com/sites/dgraph-docs/deploys/5fda5726ee114c0009e507b9 😎 Browse the preview: https://deploy-preview-7143--dgraph-docs.netlify.app |
jarifibrahim
approved these changes
Dec 17, 2020
NamanJain8
added a commit
that referenced
this pull request
Jan 6, 2021
…ue to ZeroSnapshot (#7249) We introduced a change in #7143 that would have been breaking for the next release v21.03. That change should have been a part of release/v20.11 but was mistakenly missed. We are doing a revert so that release/v21.03 is not breaking due to that change. Co-authored-by: Ibrahim Jarif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In zero's raftwal meta, we used to store
MembershipStateonly. The changes in #7096 made it storeZeroSnapshot.IndexandCheckpointTsactually need not be stored.This PR makes raftwal meta store only
MembershipState.This change is