fix(race): fixing race condition with closer use + assign uids + bgindex test fix #7266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
aman-bansal
force-pushed
the
aman/fix_alpha_race_conditions
branch
from
c8b0fee to
a0d8834
Compare
jarifibrahim
suggested changes
Jan 11, 2021
aman-bansal
force-pushed
the
aman/fix_alpha_race_conditions
branch
from
a0d8834 to
970c21c
Compare
| @@ -196,7 +196,7 @@ func (s *Server) AssignUids(ctx context.Context, num *pb.Num) (*pb.AssignedIds, | |||
|
|
|||
| select { | |||
| case <-ctx.Done(): | |||
| return reply, ctx.Err() | |||
| return &emptyAssignedIds, ctx.Err() | |||
There was a problem hiding this comment.
why do you need to change this?
There was a problem hiding this comment.
There is a race condition with the use of reply. This happens when ctx.Done was called but lease is still working to assign uids
| @@ -19,109 +19,8 @@ services: | |||
| source: ../../ee/acl/hmac-secret | |||
| target: /secret/hmac | |||
| read_only: true | |||
| command: /gobin/dgraph alpha --my=alpha1:7080 --zero=zero1:5080,zero2:5080,zero3:5080 | |||
There was a problem hiding this comment.
So this PR has 3 changes?
- closer fix
- Assign UID fix
- bgindex fix?
There was a problem hiding this comment.
yes, this PR has above three fix. let me change the description also
aman-bansal
changed the title
jarifibrahim
approved these changes
Jan 11, 2021
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
aman-bansal
added a commit
that referenced
this pull request
Jan 12, 2021
* fix(race): fixing race condition in localcache (#7140) * fixing race condition in localcache * name refactor * fixing race in pick postings + fixing race log in t.go (#7149) * fixing race condition in process subgraph (#7156) * fixing race condition in disk storage sync and save (#7263) * fixing bgindex + fix alpha z.closer (#7266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is