chore(perf): Improve perf of bulk loader with Reuse allocator and assinging tags to allocator (#7360) #7547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-bansal
requested review from
danielmai,
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
Instead of creating a new z.Allocator for every encoder, this PR reuses the allocator. On a 21M dataset, bulk loader takes 2m22s on master, and only 1m35s on this PR. That's a major 35% performance improvement.
aman-bansal
force-pushed
the
aman/bulk_loader_perf
branch
from
ebed678 to
304662e
Compare
NamanJain8
approved these changes
Mar 23, 2021
jarifibrahim
approved these changes
Mar 23, 2021
|
I have checked the basic bulk loader flow. I will ask for more comprehensive testing from QA around bulk loader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-pick of #7360 and #7516. This solves the performance of reduce phase of bulk loader which was taking too much time because of more frequent GC(allocator fix) and numerous runtime.Caller calls (tags change)
This change is