[BREAKING] feat(flags): expand badger to accept all valid options #7677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/cache-flags
branch
from
5b9a886 to
81cce15
Compare
Base automatically changed from
rohanprasad/add_cache_superflag
to
release/v21.03
April 1, 2021 17:22
NamanJain8
changed the title
NamanJain8
changed the title
jarifibrahim
approved these changes
Apr 5, 2021
NamanJain8
commented
Apr 5, 2021
NamanJain8
added a commit
that referenced
this pull request
Apr 9, 2021
) Makes --badger flag to accept all the valid badger options (except Logger & EncryptionKey). Additionally. it accepts input for "compression" with following values [none, snappy, zstd:<level>]. Corresponding PRs in badger: dgraph-io/badger#1688, dgraph-io/badger#1689 It also renames "goroutines" subflag of --badger to "numgoroutines". Also, it removes "cache-size" and "cache-percentage" subflag from --badger in bulk command. Additionally, this also moves the max-retries under --limit. (cherry picked from commit 14c2b72)
NamanJain8
added a commit
that referenced
this pull request
Apr 9, 2021
) Makes --badger flag to accept all the valid badger options (except Logger & EncryptionKey). Additionally. it accepts input for "compression" with following values [none, snappy, zstd:<level>]. Corresponding PRs in badger: dgraph-io/badger#1688, dgraph-io/badger#1689 It also renames "goroutines" subflag of --badger to "numgoroutines". Also, it removes "cache-size" and "cache-percentage" subflag from --badger in bulk command. Additionally, this also moves the max-retries under --limit. (cherry picked from commit 14c2b72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
--badgerflag to accept all the valid badger options (except Logger & EncryptionKey). Additionally. it accepts input for"compression"with following values [none, snappy, zstd:].Corresponding PRs in badger: dgraph-io/badger#1688, dgraph-io/badger#1689
It also renames
goroutinessubflag of--badgertonumgoroutines. Also, it removescache-sizeandcache-percentagesubflag from--badgerinbulkcommand.Additionally, this also moves the max-retries under --limit.
This change is