-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(core): Fix performance issue in type filter #9065
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
657293e
Fix performance issue in perf
harshil-goel 8375b71
fixed lint
harshil-goel a363d1d
added logs and tests
harshil-goel 24be5b3
skipped a test
harshil-goel 7e89d5a
fixed tlstest
harshil-goel 73974fb
fixed some tests
harshil-goel bbcdb01
updated comments
harshil-goel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,20 @@ | ||
-----BEGIN CERTIFICATE----- | ||
MIIDoTCCAomgAwIBAgIUZ5KX/PG4T1IdcXFTNIE4NHsynPYwDQYJKoZIhvcNAQEL | ||
BQAwRjEaMBgGA1UEChMRRGdyYXBoIExhYnMsIEluYy4xFzAVBgNVBAMTDkRncmFw | ||
aCBSb290IENBMQ8wDQYDVQQFEwY2OGI2M2YwHhcNMjIwOTE2MjE0NzE3WhcNMjMw | ||
OTE2MjE0NzE3WjAZMRcwFQYDVQQDDA5EZ3JhcGggUm9vdCBDQTCCASIwDQYJKoZI | ||
hvcNAQEBBQADggEPADCCAQoCggEBAMXmk4xCtVfwxqYwdfOUYU3bHoRmMzmNWxBU | ||
uw8ztf67y8HHNVyKXW6l0AqlxssfOjEiq0gE+U0RUpjOzJnvvhi2YEtwcM9mXrgi | ||
vd7M+AJlUGCjhUJbzbaEU3+XsUCQY+R76pvad7vNSdMAM+9bivWEj4A76H2OBsTA | ||
qJ8ZAvCThpofUTbkVDQDo39u95oYBGEc7dFMZ+H7kUTAzvU7hhQJ/IGdNkGvERN8 | ||
QAhQdHYPAnmWbk7ClLVtJFrqYXbOdCpMZ13DnyFIZg4kyoYAPuF5xcatG/dLMxbv | ||
Pi/lsswtWWzyoxNIbkXO/g9nV3tgvt+yLkFgH0CAcrF82SsnPPECAwEAAaOBszCB | ||
sDAJBgNVHRMEAjAAMA4GA1UdDwEB/wQEAwIHgDATBgNVHSUEDDAKBggrBgEFBQcD | ||
AjAdBgNVHQ4EFgQUNRAV4RX3uVWtkdrBvc8nrbMWQJkwXwYDVR0jBFgwVqFKpEgw | ||
RjEaMBgGA1UEChMRRGdyYXBoIExhYnMsIEluYy4xFzAVBgNVBAMTDkRncmFwaCBS | ||
b290IENBMQ8wDQYDVQQFEwY2OGI2M2aCCGi2Pw9IyWXoMA0GCSqGSIb3DQEBCwUA | ||
A4IBAQBfPboePF0LV7EqSDXg/yMeCuIIDJdscHkO1QRB7q40AF0zHz3r1KM2OhNb | ||
MLXsavjRqIOQQvpTQ2uBuE9H6i632nTWxxYYedk07ijIv6ppmXZDV5V3dkSKQIhA | ||
SqC0+ZRSK5FkHDDM+UpK+3s/MRwbDS2GDgG9wwe5LsFiucwu/YSsgkk/vcZtbT3w | ||
L8qJXeB6RpeqgkfUnQ2Quuatzkn9MCRTZizK7ZRmCqoGcTgy14ur2OqCZPrp5wUy | ||
dLMNO2DUK9o2y9fdAxOShnjSF4PHVwyBTNRe4FAo7aJmyDvA+HFAoa1Dd5YHP6V+ | ||
4PXQVf6wnRhlIYVKTOT1IyBT4nGe | ||
MIIDLTCCAhWgAwIBAgIISKhf4mg1jUIwDQYJKoZIhvcNAQELBQAwRjEaMBgGA1UE | ||
ChMRRGdyYXBoIExhYnMsIEluYy4xFzAVBgNVBAMTDkRncmFwaCBSb290IENBMQ8w | ||
DQYDVQQFEwY2OGI2M2YwHhcNMjMwOTI0MTUyNzA0WhcNMjQwOTI0MTUyNzA0WjA+ | ||
MRowGAYDVQQKExFEZ3JhcGggTGFicywgSW5jLjEPMA0GA1UEAxMGYWxwaGExMQ8w | ||
DQYDVQQFEwY0OGE4NWYwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDM | ||
2a7UimfMOA11ycma20Sn3rmKnyqUBvmz9cofLXbhdNJ0xxVJ+Z4BZrNpAzTDMwYK | ||
UlnBwL34gxG2XulJZwhqYhehB4h8YehPLLBw87ytebJnj72mWP50YBawf5LL3X24 | ||
DOdXVEsK/8D3RCojvCNSkH6QcrKZ0jTNffFQhdpccq0EofcwEdXRiluepCxLZQfa | ||
a4EiaGsOdizZTK7NP1VZoFKphVSO3h0S2ohmr4hLm0ft79TyaE/CGfpsvlIp/luE | ||
Usha43KP6PRohrqJEb2ly2CW7QI2deQc1iRw9ozZDPYu+YLVw7O7T4IeUUO4BPwU | ||
ad68YF3d5cizryQPJ9o5AgMBAAGjJzAlMA4GA1UdDwEB/wQEAwIHgDATBgNVHSUE | ||
DDAKBggrBgEFBQcDAjANBgkqhkiG9w0BAQsFAAOCAQEACE3yD6+Yy/Pr+3+8hE6Z | ||
V8V8DIUXE+RV/yEUQNyMaS+Dv9UFZjqk9Su0Diax7Vace0Y3vO15MPk6TSIhJzoF | ||
fxu2/wRnpK4ddJVpWrast2KAFJDnOeaFG3WG6dk22C7ESlZLv49ZwIm+SzWrZ/i3 | ||
NLqylhy0U/ciMyKDUAn2wEYpYjZjkap74UgwAcl1lVYdc5oUBRkj1KCMTZBipQBV | ||
FJVcYXfFHZbqxB+MIhABummpQIfI9Vvf5AiwBWwpv5VelRALtk9RcQCRlwWi6euM | ||
P47ddD9C626UfhY/s1vwSUq11YjX+MpE67I1bfDLwkBH1y/uLStK0kY13KOCtgty | ||
cw== | ||
-----END CERTIFICATE----- |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we clarify this message in some way to be more useful to someone who is not familiar with internal workings? Also include which posting list if that is available.
I think this means that the badger values representing a posting list (in 256KB chunks IIRC) contained many deleted structures, and are doing more than 50% of the data movement for non-useful deleted data.
If so something like: "High proportion of deleted data observed for posting list {l.key}: total = {numNormal+numdeleted}, percent deleted = {numDel / (numnormal+numdel) * 100}%".