Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle gen bug #324

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Bundle gen bug #324

merged 5 commits into from
Mar 3, 2023

Conversation

Zetazzz
Copy link
Collaborator

@Zetazzz Zetazzz commented Mar 1, 2023

mobx generating shouldn't depend on pinia options
try to fix bundle file bug for state manager

@pyramation
Copy link
Collaborator

this is a great way to do this!

@pyramation
Copy link
Collaborator

looks like we just need to update the snapshots for the pinia tests for this to pass

cc @Zetazzz @liangping

@Zetazzz
Copy link
Collaborator Author

Zetazzz commented Mar 2, 2023

Cool, I've included snapshot fix in the doc PR, we can get this fixed after it's merged. Thank you very much!

@pyramation pyramation merged commit 548683f into hyperweb-io:main Mar 3, 2023
@Zetazzz Zetazzz deleted the bundle-gen-bug branch March 7, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants