Protocol Integration

[jackyzha0]

Closes hyphacoop/distributed-press-organizing#62

• API calls now hooks up with appropriate protocols based on config

[RangerMauve]

Awesome! I like where this is going. Some minor nits but I think this is a better structure from before. sync vs unsync is good wording for it IMO.

@fauno Heads up, this changes the HTTP API a bit for updating site data.

[fauno]

@fauno Heads up, this changes the HTTP API a bit for updating site data.

Could you point me to those changes? I saw there's a change on NewSite and publication changed to a protocolos object of protocol: Boolean pairs?

[fauno]

Could you point me to those changes? I saw there's a change on NewSite and publication changed to a protocolos object of protocol: Boolean pairs?

Nevermind, I'm reading the files :)

[fauno]

i'm having this tsc error when running dev script after the last commit, removing the whole block of sync code con v1/api/sites.ts works for the tests i was doing.

config/sites.ts(34,13): error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index ty
pe '{ ipfs: boolean; hyper: boolean; http: boolean; }'.             
  No index signature with a parameter of type 'string' was found on type '{ ipfs: boolean; hyper: boolean; http: boolean; }'.
config/sites.ts(35,27): error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index ty
pe 'ProtocolManager'.                                                                                                                   
  No index signature with a parameter of type 'string' was found on type 'ProtocolManager'.
config/sites.ts(37,20): error TS7006: Parameter 'protocolLinks' implicitly has an 'any' type.
config/sites.ts(38,15): error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index ty
pe 'Partial<{ ipfs: { gateway: string; cid: string; pubKey: string; } & { link: string; enabled: boolean; }; hyper: { gateway: string; r
aw: string; } & { link: string; enabled: boolean; }; http: {} & { link: string; enabled: boolean; }; }>'.
  No index signature with a parameter of type 'string' was found on type 'Partial<{ ipfs: { gateway: string; cid: string; pubKey: string
; } & { link: string; enabled: boolean; }; hyper: { gateway: string; raw: string; } & { link: string; enabled: boolean; }; http: {} & { 
link: string; enabled: boolean; }; }>'.

not sure if this change affects the api endpoints, i'd have to adapt the client. it seems to work for a nanoid still, but not sure if internally it thinks it's the domain name

-    const id = nanoid()                                                                                                                
+    const id = cfg.domain                                                                                                              

[RangerMauve]

Oh, I messed up some typescript types, working on fixing it now

[RangerMauve]

Just gonna add some more fixes for the protocol stuff first

[RangerMauve]

Make sure to do an npm install call after pulling.

[RangerMauve]

Remaining steps:

• Wait for js-ipfs-http-client to update with the key gen fix: fix: ipfs-http-client should lowercase key type when submitting to kubo ipfs/js-ipfs#4303
• Get a basic JS test for uploading Formdata using the new site.tar.gz fixture and the form-data module Question: How to upload a file? fastify/light-my-request#35
• Fix js-ipfs-mfs-sync erroring due to Kubo not implementing ipfs.files.touch

[RangerMauve]

Other than the one nit pic I think this is good to go!

Mind addressing the comment and then merging in?

Also, I really like your approach of adding a context to tests for setup and teardown.

[RangerMauve]

Does throw not work for this case? If it's a linter thing, I'd appreciate it if we could disable whatever rule is mandating this code style. :P