Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grimblast: allow decimals for --wait #127

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

arminius-smh
Copy link
Contributor

Description of changes

grimblast --wait currently only allows whole numbers, and I myself like to use it to get the cursor out of the way for screenshots, however a whole second is just a bit too unnatural too long for me and I'd like to use something like 0.5 or 0.7, so I've changed the regex to allow adding decimal numbers (I hope the regex is alright)

The usage still says [--wait N] but I initally expected N to also include decimal numbers, so not sure if this should just stay the same or if the usage should also mention that decimals are allowed, although I think that may be a bit confusing and should just stay this way

Things done

  • For new programs

    • Add the program to the README table, with yourself as the
      maintainer
    • Add a README for the program itself
    • Add Makefile (and Nix derivation optionally, otherwise @fufexan will do
      it)
    • If the program is a script, add it to the
      CI checks matrix
  • For changes

@fufexan
Copy link
Member

fufexan commented Jan 25, 2025

not sure if this should just stay the same or if the usage should also mention that decimals are allowed, although I think that may be a bit confusing and should just stay this way

Let's add that clarification in the manpage.

@arminius-smh arminius-smh force-pushed the grimblast-allow-decimals branch from f45dff3 to ff501fa Compare January 25, 2025 16:15
@arminius-smh
Copy link
Contributor Author

Let's add that clarification in the manpage.

Done 👍

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fufexan fufexan merged commit 2967407 into hyprwm:main Jan 25, 2025
7 checks passed
@arminius-smh arminius-smh deleted the grimblast-allow-decimals branch January 25, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants