Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label: fix rendering with multiple timers that fire at the same time #147

Merged
merged 1 commit into from
Mar 7, 2024
Merged

label: fix rendering with multiple timers that fire at the same time #147

merged 1 commit into from
Mar 7, 2024

Conversation

PaideiaDilemma
Copy link
Collaborator

@PaideiaDilemma PaideiaDilemma commented Mar 7, 2024 •
edited
Loading

The problem is that getAssetByID might return a nullptr if asyncLoopState.busy is true.
In that case the callback of asyncResourceGatherer does trigger rendering, but the asset is not getting updated.

Not sure if you want to re-render like this or handle this case (asyncLoopState.busy beeing true) specifically.

Fixes #134

vaxerski
vaxerski approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaxerski vaxerski merged commit e9a57f0 into hyprwm:main Mar 7, 2024
1 check passed
@asiantuntija asiantuntija mentioned this pull request Mar 8, 2024
Closed
PaideiaDilemma added a commit to PaideiaDilemma/hyprlock that referenced this pull request Mar 8, 2024
@PaideiaDilemma
Revert "label: fix rendering with multiple timers that fire at the sa…
db922e2 
…me time (hyprwm#147)"

This reverts commit e9a57f0.
PaideiaDilemma added a commit to PaideiaDilemma/hyprlock that referenced this pull request Mar 8, 2024
@PaideiaDilemma
Revert "label: fix rendering with multiple timers that fire at the sa…
5df604e 
…me time (hyprwm#147)"

This reverts commit e9a57f0.
@PaideiaDilemma PaideiaDilemma mentioned this pull request Mar 8, 2024
Merged
vaxerski pushed a commit that referenced this pull request Mar 8, 2024
@PaideiaDilemma
label: Fix label updates (#152)
b4a1c8c 
* label: render output via stringPort instead of surface

* label: retry onAssetCallback

Calling `render` might not update the asset when the surfaces frameCallback is already set.

* Revert "label: fix rendering with multiple timers that fire at the same time (#147)"

This reverts commit e9a57f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Label is not updating without input-field
2 participants
@PaideiaDilemma @vaxerski