Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-field: fail display improvments #154

Merged
merged 5 commits into from
Mar 9, 2024
Merged

input-field: fail display improvments #154

merged 5 commits into from
Mar 9, 2024

Conversation

bvr-yr
Copy link
Contributor

@bvr-yr bvr-yr commented Mar 8, 2024

  • pango-parseable fail_text with $FAIL as pam fail-reason
  • fail_color to change untagged text color and outer color
  • fail_transition to configure transition time between outer and fail
  • temporarily resize input-field if fail-message is too long

should fix #97 (#97 (comment))
also accidentally fixed #144, but i'm not sure, maybe it is intended behaviour?
if so, i'll just add check in resize thing to not reshadow if fade_on_empty = true

i definitely focked-up somewhere, so double-check plz ❤️

ufail.mp4

@bvr-yr
Copy link
Contributor Author

bvr-yr commented Mar 9, 2024

hmm wait.. do actual env vars expand now? i mean not this MR
i believe it was not so some time ago, or was it always like that?

looks odd xD
lul

upd:
yeah v0.1.0 also expands
don't think that's a problem, probably just prefix all hyprlock vars with HL_ but this is breaking
or probably add ability to hyprlang to escape $VAR with $$ to make it literal, i didn't find way to escape it

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm I guess, wiki mr needed

@vaxerski vaxerski merged commit 149b673 into hyprwm:main Mar 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]fade_on_empty = true doesn't give the input field a shadow Cant see if i typed wrong the password
2 participants