core: stabilize label updates and revision locking in the asyncResourceGatherer #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes getAssetById fail less often and thus labels get more stable updates
`assetsMutex` was not needed, since `apply` only gets called from the main thread and resources are also only aquired via the main thread. `preloadTargets`, previously kinda guarded by the `busy` flag are now locked as suggested in hyprwm#367 (but via a copy of `peloadTargets`). `apply` now returns a boolean so that the locking of preloadTargets in combination with checking `preloadTargets.empty()` is a bit nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to repro #357 (multiple monitors required i think).
Fixes it on my end.
4509552 reverts the previous approach of adding a timer to re-render, when the resource was not available (#152). It also sets
needsFrame=true, when render is called butframeCallbackis present (I think not 100% needed but still makes sense)The other 3 commits make sure that
getAssetByIdfails less often by removing thebusyflag and revisioning the locking in the resource gatherer.-fsanitize=threadis a bit happier regarding the asyncResourceGatherer now. Besides some races withdmason startup I think.Closes #367