Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: add --no-fade-in #453

Merged
merged 1 commit into from
Aug 3, 2024
Merged

renderer: add --no-fade-in #453

merged 1 commit into from
Aug 3, 2024

Conversation

alba4k
Copy link
Contributor

@alba4k alba4k commented Aug 3, 2024

This PR implements what I wished for in #452

It simply adds a --no-fade-in flag that disables the fade in animation when used, overwriting the use of no_fade_in (as if it was always set to true).

For the implementation, I mainly looked at the way --immediate-render was implemented.

LMK if there are any changes I should make, the main doubts I have are:

  • is the internal m_bNoFafeIn name correct? not sure what the m and the b stand for.
  • the commit name, should it start with renderer:? Would something else like core: be better?

@alba4k alba4k changed the title renderer: add --no-fadein renderer: add --no-fade-in Aug 3, 2024
src/core/hyprlock.hpp Show resolved Hide resolved
@vaxerski vaxerski merged commit 5d85ea0 into hyprwm:main Aug 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants