input-field: Fix crash when numlock is on and numlock_color is fallback #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Hyprlock crashes in
updateColors()
when:colorConfig.num
is a fallback value.There is an inconsistency in condition checks when assigning and later using
targetGrad
:When assigning
targetGrad
(Line 409), the condition checks both:colorConfig.num
is not a fallback.When using
targetGrad
(Line 421), the condition only checks for numlock, but does not check ifnumlock_color
is a fallback.numlock_color
is a fallback,targetGrad
remainsnullptr
, leading to a crash.Fix
targetGrad
.