Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/improve streamlit #132

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Feature/improve streamlit #132

merged 6 commits into from
Mar 21, 2024

Conversation

252afh
Copy link
Contributor

@252afh 252afh commented Mar 21, 2024 •
edited
Loading

Context

  • Breaking down of Liam's PR into chunks for optimising docker images
  • Some initial changes to the streamlit app and ruff formatting

Changes proposed in this pull request

  • Changed dockerfile to remove some groups from install
  • Changed docker-compose to docker compose
  • Ruff formatting

Guidance to review

Check that the streamlit app still runs

Relevant links

#121

@252afh 252afh marked this pull request as ready for review March 21, 2024 10:51
gecBurton
gecBurton approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible to me

@252afh 252afh merged commit 7eba5fc into main Mar 21, 2024
3 checks passed
@252afh 252afh deleted the feature/improve-streamlit branch March 21, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gecBurton gecBurton gecBurton approved these changes

@tayyib-saddique tayyib-saddique tayyib-saddique approved these changes

@lmwilkigov lmwilkigov lmwilkigov approved these changes

@KevinEtchells KevinEtchells Awaiting requested review from KevinEtchells

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@252afh @gecBurton @tayyib-saddique @lmwilkigov