Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rename embed ingest to be sensible #150

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Feature/rename embed ingest to be sensible #150

merged 5 commits into from
Mar 26, 2024

Conversation

252afh
Copy link
Contributor

@252afh 252afh commented Mar 26, 2024

Context

Embed and Ingest could be made more grammatically correct by renaming them to ingester and embedder

Changes proposed in this pull request

  • Changed directory names
  • Change poetry group names
  • Change usages of ingest to ingester where appropriate and left ingest where appropriate

Guidance to review

Test that ingester builds through docker-compose still

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests locally

@252afh 252afh requested review from gecBurton and lmwilkigov March 26, 2024 12:09
@252afh 252afh marked this pull request as ready for review March 26, 2024 12:27
gecBurton
gecBurton requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMD ["faststream", "run", "ingest.src.worker:app"]

should be

CMD ["faststream", "run", "ingester.src.worker:app"]

gecBurton
gecBurton approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic

@gecBurton gecBurton merged commit d30c9d9 into main Mar 26, 2024
5 checks passed
@gecBurton gecBurton deleted the feature/rename-embed-ingest-to-be-sensible branch March 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gecBurton gecBurton gecBurton approved these changes

@lmwilkigov lmwilkigov Awaiting requested review from lmwilkigov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@252afh @gecBurton