bugfix/implicit single connection #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
bugfix/REDBOX-154-single-connection-to-redis-broker-in-core-api
branch
from
4794b8b to
8896f46
Compare
lmwilkigov
approved these changes
Apr 15, 2024
gecBurton
force-pushed
the
bugfix/REDBOX-154-single-connection-to-redis-broker-in-core-api
branch
from
2365308 to
5c4b99e
Compare
gecBurton
deleted the
bugfix/REDBOX-154-single-connection-to-redis-broker-in-core-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The fast stream redis broker does not operate to automatically connect within a sub application. to get round this we have been establishing the connection each time a file is posted. In this PR we ensure this happens only once.
Changes proposed in this pull request
As I could not find thus issue addressed in the fast stream documentation I have created a class to manage the brokers lifecycle so that the connection is only made once
Guidance to review
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-154
Things to check