Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser console errors #227

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

KevinEtchells
Copy link
Contributor

Context

While working on something else, I noticed a couple of browser console errors:

  • The gov.uk inline script is being blocked by our Content Security Policy (meaning no gov.uk javascript is running)
  • Missing manifest.json file

This update addresses both of these issues.

Changes proposed in this pull request

  • Update the CSP to allow the inline script (but only this inline script) by using a hash
  • Add the manifest.json file to the project. This alone didn't fully fix the problem, but removing the whitespace from the URL did

Guidance to review

  • Visit any page and check there are no browser console errors
  • Please look at the CSP changes in settings.py to confirm they are sensible

Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot!

@KevinEtchells KevinEtchells merged commit 0d86069 into main Apr 15, 2024
5 checks passed
@KevinEtchells KevinEtchells deleted the bugfix/browser-console-errors branch April 15, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants