Feature/help pages #233

KevinEtchells · 2024-04-16T07:20:30Z

Context

Updating the Privacy, Accessibility and Support pages to fit in with Redbox Copilot.

Jira ticket: https://technologyprogramme.atlassian.net/jira/software/projects/REDBOX/boards/409?selectedIssue=REDBOX-69

Changes proposed in this pull request

Setup pages to use the base HTML template
Update page content
Add links to footer

Guidance to review

Check the footer links work
Check the content reads okay and is suitable for Redbox Copilot (some bits may need updating at a later date, but this should provide a sensible default/starting point)

252afh · 2024-04-16T08:14:13Z

django_app/redbox_app/templates/accessibility-statement.html

-{% block title %}
-  <title>Accessibility statement - Redbox Copilot - GOV.UK</title>
-{% endblock %}
+{% set pageTitle = "Accessibility statement" %}


The old style is the GDS way of doing it, might be worth keeping it that way

Interesting. I'm definitely keen to follow existing convention where possible, but the "new" approach offers the following advantages:

Reduces the risk of a mistake (e.g. missing <title> element)

It doesn't need to be a block as it's only plain text that changes

Reduces repetition and therefore makes updating the site name easier

Reduces the risk of inconsistencies creeping in

It's just a question of whether these advantages are enough to move away from the GDS way. The advantages are only small. What do you reckon?
(if we change back I'll create a ticket, as it'll mean changes on other pages too - still a tiny job though)

252afh · 2024-04-16T08:18:16Z

django_app/redbox_app/templates/accessibility-statement.html

-    <p>This website is run by the Cabinet Office. We want as many people as possible to be able to use this website. For example, that means you should be able to:</p>
+  <h1 class="govuk-heading-l">Accessibility statement for Redbox Copilot</h1>
+
+    <p class="govuk-body">This accessibility statement applies to Redbox Copilot.</p>


You should only have to add govuk-body to the body tag in base.html

Yes, true, but strangely the spacing was more (too) condensed when it had that. I'll take another look as it'd be tidier to only have it once.

Because .govuk-body has a margin-bottom set on it, this will be missed if it's only used on a container element. That explains why it's needed for the spacing. Though there will be contexts where it'll be okay, I don't believe this is one. There are also styles for heading elements immediately preceeded by .govuk-body.

Looking on gov.uk there are examples of <p> elements without govuk-body. In those cases they have the styles on a custom container class, e.g. .container-class > p. I believe this is because their hand is forced due to the content coming from a CMS. There's no mention of a container class in the design system docs (from what I can see), and I can't see one looking through the CSS.

252afh · 2024-04-16T08:18:48Z

django_app/redbox_app/templates/accessibility-statement.html

+  <h1 class="govuk-heading-l">Accessibility statement for Redbox Copilot</h1>
+
+    <p class="govuk-body">This accessibility statement applies to Redbox Copilot.</p>
+    <p class="govuk-body">This website is run by the Cabinet Office. We want as many people as possible to be able to use this website. For example, that means you should be able to:</p>
    <ul class="govuk-list govuk-list--bullet">
      <li>change colours, contrast levels and fonts</li>


Is this first point possible? We might need to remove it

The "change colours" etc. bit? If so, then yes, through user stylesheets and browser settings. There's also things like high contrast mode at OS level. It's one (of several) reasons why web pages are more accessible (out of the box) than PDFs.

252afh · 2024-04-16T08:19:48Z

django_app/redbox_app/templates/accessibility-statement.html

-      </ul>
-    <p>We'll consider your request and get back to you in 14 days.</p>
-
+    <p class="govuk-body">If you need information on this website in a different format like accessible PDF, large print, easy read, audio recording or braille, email <a href="mailto:[email protected]" class="govuk-link">[email protected]</a></p>


You should be able to use the {{CONTACT_EMAIL}} env var if we have it in this project to make it easier to update if it changes

Yeah, that's a good point. I'll take a look!

I've added that in now, and added the correct email address to the example .env files

252afh · 2024-04-16T08:21:12Z

django_app/redbox_app/templates/accessibility-statement.html

    <h2 class="govuk-heading-m">Enforcement procedure</h2>
-    <p>The Equality and Human Rights Commission (EHRC) is responsible for enforcing the Public Sector Bodies (Websites and Mobile Applications) (No. 2) Accessibility Regulations 2018 (the "accessibility regulations"). If you're not happy with how we respond to your complaint, <a href="https://www.equalityadvisoryservice.com/" class="govuk-link">contact the Equality Advisory and Support Service (EASS)</a>.</p>
+    <p class="govuk-body">The Equality and Human Rights Commission (EHRC) is responsible for enforcing the Public Sector Bodies (Websites and Mobile Applications) (No. 2) Accessibility Regulations 2018 (the "accessibility regulations"). If you're not happy with how we respond to your complaint, <a href="https://www.equalityadvisoryservice.com/" class="govuk-link">contact the Equality Advisory and Support Service (EASS)</a>.</p>


Has the UK withdrawn from EHRC?

No idea! @Samuel-Hoskin tagging you in incase you know?

The Equality and Human Rights Commission is non-departmental body of the UK Government. It is not tired to EU law

We have not withdrawn

Thank you @Samuel-Hoskin and @lmwilkigov

252afh · 2024-04-16T08:22:41Z

django_app/redbox_app/templates/accessibility-statement.html


+    <h2 class="govuk-heading-m">Preparation of this accessibility statement</h2>
+    <p class="govuk-body">This statement was prepared in 27th February 2024. It was last reviewed on 12th April 2024.</p>


in to on

252afh · 2024-04-16T08:25:29Z

django_app/redbox_app/templates/base.html

@@ -76,6 +76,24 @@
    <div class="govuk-width-container">
      <div class="govuk-footer__meta">
        <div class="govuk-footer__meta-item govuk-footer__meta-item--grow">
+          <h2 class="govuk-visually-hidden">Support links</h2>


Side note in this doc, can we update Up to UK OFFICIAL SENSITIVE documents can be used in this tool to say explicitly whether it includes or doesn't include OS

I'll make a note to check this separately

252afh · 2024-04-16T08:29:13Z

django_app/redbox_app/templates/privacy-notice.html

    <p class="govuk-body">We may change this privacy notice. When we make changes to this notice, the "last updated" date at the bottom of this page will also change. Any changes to this privacy notice will apply to you and your data immediately. If these changes affect how your personal data is processed, Cabinet Office will take reasonable steps to make sure you know.</p>
-    <p class="govuk-body">Last updated: 27th February 2024</p>
+    <p class="govuk-body">Last updated: 11th April 2024</p>


Make sure this date changes last thing

252afh · 2024-04-16T08:42:17Z

django_app/redbox_app/templates/support.html

-  <span class="govuk-caption-l">Find out about the One Big Thing website, including how to sign in and use your <SYSTEM_NAME> account.</span>
-  <br>
+
+  {#


Never seen this syntax before and I'm curios, what does it do?

{# Anything inside here is a comment #}
Better (in some cases) than  as it won't be rendered as part of the HTML.
I just wanted to keep that as a reference incase we want to put anything similar back in.

252afh · 2024-04-16T08:43:02Z

django_app/redbox_app/templates/support.html


- <h2 class="govuk-heading-m">Email address not allowed</h2>
+  <h2 class="govuk-heading-m">Email address not allowed</h2>


Could you add a ticket to the backlog to come update this once the auth solution is in place please?

Yep, good shout.

https://technologyprogramme.atlassian.net/jira/software/projects/REDBOX/boards/409?selectedIssue=REDBOX-159

Update contact email address

252afh approved these changes Apr 16, 2024

View reviewed changes

KevinEtchells temporarily deployed to release April 17, 2024 07:22 — with GitHub Actions Inactive

KevinEtchells added 2 commits April 17, 2024 08:22

Update help pages and add links to footer

bccb8f4

Update contact email address

Use env var for contact email

426a737

KevinEtchells force-pushed the feature/help-pages branch from 94cde66 to 426a737 Compare April 17, 2024 07:23

KevinEtchells temporarily deployed to release April 17, 2024 07:23 — with GitHub Actions Inactive

KevinEtchells merged commit 7be4e0d into main Apr 17, 2024
6 of 7 checks passed

KevinEtchells deleted the feature/help-pages branch April 17, 2024 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/help pages #233

Feature/help pages #233

KevinEtchells commented Apr 16, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024 •

edited

Loading

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024 •

edited

Loading

KevinEtchells Apr 17, 2024 •

edited

Loading

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

KevinEtchells Apr 17, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

Samuel-Hoskin Apr 16, 2024

lmwilkigov Apr 16, 2024

KevinEtchells Apr 17, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

252afh Apr 16, 2024

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024 •

edited

Loading

252afh Apr 16, 2024

KevinEtchells Apr 16, 2024

KevinEtchells Apr 16, 2024


		<h2 class="govuk-heading-m">Preparation of this accessibility statement</h2>
		<p class="govuk-body">This statement was prepared in 27th February 2024. It was last reviewed on 12th April 2024.</p>


		<h2 class="govuk-heading-m">Email address not allowed</h2>
		<h2 class="govuk-heading-m">Email address not allowed</h2>

Feature/help pages #233

Feature/help pages #233

Conversation

KevinEtchells commented Apr 16, 2024

Context

Changes proposed in this pull request

Guidance to review

Choose a reason for hiding this comment

KevinEtchells Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KevinEtchells Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

KevinEtchells Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KevinEtchells Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KevinEtchells Apr 16, 2024 •

edited

Loading

KevinEtchells Apr 16, 2024 •

edited

Loading

KevinEtchells Apr 17, 2024 •

edited

Loading

KevinEtchells Apr 16, 2024 •

edited

Loading