Feature/health endpoints for workers #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 18, 2024 06:49
gecBurton
force-pushed
the
feature/health-endpoints-for-workers
branch
from
c242579 to
9fee7aa
Compare
gecBurton
force-pushed
the
feature/health-endpoints-for-workers
branch
from
669a8d3 to
94f2713
Compare
added 3 commits
April 18, 2024 09:01
252afh
reviewed
Apr 18, 2024
252afh
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
ECS tasks need to have an http healthcheck
Changes proposed in this pull request
faststreamworkers are now embedded withinfastapi, following https://faststream.airt.ai/latest/getting-started/integrations/fastapi/core-api/healthendpointpyproject.tomldependencies, note that we have to pinfaststreamat < 0.5 (I suspect they have some more breaking changes)Guidance to review
Relevant links
Things to check