Feature/redbox 169 merge embedder and ingester into one service #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmwilkigov
approved these changes
Apr 26, 2024
…er-into-one-service
…er-into-one-service
lmwilkigov
deleted the
feature/REDBOX-169-merge-embedder-and-ingester-into-one-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As the embedder and ingester are very similar services, with near identical architectures and requirements it makes sense to merge them.
Changes proposed in this pull request
embedderinto theingesteringester->workerGuidance to review
Relevant links
Things to check