Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlflow - connecting endpoints to tracking server #277

Merged
merged 20 commits into from
May 10, 2024

Conversation

tayyib-saddique
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@tayyib-saddique tayyib-saddique marked this pull request as draft April 25, 2024 15:57
@tayyib-saddique tayyib-saddique changed the title Experiment mlflow prompt testing mlflow - connecting endpoints to tracking server May 1, 2024
@tayyib-saddique tayyib-saddique marked this pull request as ready for review May 2, 2024 15:46
mlflow/config.yaml Outdated Show resolved Hide resolved
mlflow/docker/Dockerfile Outdated Show resolved Hide resolved
@wpfl-dbt
Copy link
Collaborator

wpfl-dbt commented May 3, 2024

Where is the tracking server storing experiments? Is the intention to deploy this so we can all see each other's experiments, and will this setup work that way?

@tayyib-saddique
Copy link
Contributor Author

Where is the tracking server storing experiments? Is the intention to deploy this so we can all see each other's experiments, and will this setup work that way?

Tracking server stores experiments locally - have discussed potential possibility to deploy in AWS so experiments can be shared in line with broader work related to DeepEval and Ragas

@tayyib-saddique tayyib-saddique force-pushed the experiment-mlflow-prompt-testing branch from da23be5 to a82fced Compare May 9, 2024 13:54
mlflow/Dockerfile Outdated Show resolved Hide resolved
@@ -33,14 +33,17 @@ services:
volumes:
- ./:/app/:z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think :z is linux specific, which gets ignored by Windows and macOS? Should we replace it with - ./app:/app to make it compatible across operating systems?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside scope of PR - the volume is in reference todjango-app, not mlflow

@@ -0,0 +1,11 @@
mlflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mlflow along okay? Or do we need mlflow[genai]? See https://mlflow.org/docs/latest/llms/deployments/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracking server connects with chat endpoints, so I'm not sure if this is needed as it deploys as intended

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have/need a ticket in the backlog to explore how to switch these OpenAI endpoints to our Redbox CoreAPI endpoint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps one to include in the backlog - definitely a good shout to explore connecting to the Redbox CoreAPI endpoint

@andy-symonds
Copy link
Contributor

andy-symonds commented May 10, 2024

Tracking server stores experiments locally - have discussed potential possibility to deploy in AWS so experiments can be shared in line with broader work related to DeepEval and Ragas

Deploying to AWS is a separate ticket/piece of work, so let's add that to the backlog to track it.

@tayyib-saddique tayyib-saddique merged commit 25a3b0a into main May 10, 2024
7 checks passed
@gecBurton gecBurton deleted the experiment-mlflow-prompt-testing branch September 11, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants