-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API error codes and implemented 404 on file endpoints #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to check the Makefile check with @gecBurton. Aside from that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely stuff!
Context
Our endpoints should provide meaningful errors. This PR adds 404, and implements it on relevant file endpoints.
On the changes to the E2E tests, the existing
make test-integration
wasn't working, and the existing solution would never extend to E2E tests involving the LLM, as we can't put API keys in.env.integration
. A blended approach of pytest using the existing.env
, but overwriting a few key vars, makes more sense.Changes proposed in this pull request
http.HTTPStatus
instead of hard-coded error numbers.env
Guidance to review
pyproject.toml
rather than.env.integration
?Relevant links
Things to check