Feature/design system #352
Conversation
KevinEtchells
force-pushed
the
feature/design-system
branch
from
c55a891 to
d209bdd
Compare
Update latest CSS bundle Tweak response feedback spacing
KevinEtchells
force-pushed
the
feature/design-system
branch
from
f1e5faf to
78992a2
Compare
| .govuk-header__navigation-list { | ||
| margin-top: 0.75rem; | ||
| } | ||
| @media (min-width: 769px) { |
There was a problem hiding this comment.
This looks different from how GDS do media queries. Is this ok?
There was a problem hiding this comment.
That's a good flag @wpfl-dbt. Usually the GDS approach would be better, but as this CSS could also be used outside of Sass I'd suggest this is okay here.
| /* BUTTON */ | ||
| .govuk-button { | ||
| border: 0; | ||
| border-radius: var(--border-radius); |
There was a problem hiding this comment.
I have a vague memory that Firefox needs a different solution for border-radius -- does this needs belt and bracing? Or have times a-changed?
There was a problem hiding this comment.
Or is this kind of thing literally why we use Sass?
There was a problem hiding this comment.
Firefox should play nicely with border-radius nowadays :-)
Sass doesn't really add anything in this context. I'm building it in a way so it doesn't rely on Sass (even though it's a .scss file) for compatibility across projects.
| @@ -15,7 +15,7 @@ <h1 class="govuk-heading-l">Sign in</h1> | |||
|
|
|||
| <input type="hidden" name="csrfmiddlewaretoken" value="{{ csrf_token }}"> | |||
|
|
|||
| <div class="govuk-form-group"> | |||
| <div class="govuk-form-group govuk-!-margin-bottom-2"> | |||
|
LGTM, both code wise and aesthetically! |
Context
Looking at building an overlay for the gov.uk design system, to provide a more bespoke look and feel. This is work-in-progress, but the work so far can be merged.
Changes proposed in this pull request
The way this works