Bugfix/fix trailing slashes by removing whitenoise #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
reviewed
May 14, 2024
| {% endcompress %} | ||
| {% else %} |
wpfl-dbt
reviewed
May 14, 2024
| @@ -9,7 +9,7 @@ | |||
| <div class="govuk-grid-column-two-thirds"> | |||
| <h1 class="govuk-heading-xl">Ask any question of documents in your Redbox</h1> | |||
| <p class="govuk-body-l">Use Artificial Intelligence (AI) to get insights from your personal document set. You can use up to, and including, Official Sensitive documents.</p> | |||
| <p class="govuk-body">If you have an account, please <a class="govuk-link" href="/sign-in">sign in</a> to get started</p> | |||
| <p class="govuk-body">If you have an account, please <a class="govuk-link" href="{{url('sign-in')}}">sign in</a> to get started</p> | |||
There was a problem hiding this comment.
I've not seen this function syntax in jinja templates before. What is it and is it safe going forward?
There was a problem hiding this comment.
This is a django/jinja2 syntax for constructing urls from the url slug. This is the better way of doing it, you can't get links that go nowhere doing it this way
There was a problem hiding this comment.
Is it the same or different to this?
wpfl-dbt
reviewed
May 14, 2024
Comment on lines
+1
to
+4
| # SASS Compilation (if not using django-compressor) | ||
|
|
||
| `npm install -g sass` | ||
| `sass style.scss style.css -w` |
There was a problem hiding this comment.
It seems like a bad idea to have, at this point, a third nested level of README.
This seems to work the opposite way around -- I go to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Whitenoise seems to be caching the pages at a single url and not respecting the trailing_slash setting. We don't really need whitenoise locally so we can just remove it.
Changes proposed in this pull request
Guidance to review
/documentsand see that you get redirected to/documents/Relevant links
Things to check