Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a User I want the model to be loaded on start up and not on every embedding, so that the embeddings are done quickly
Changes proposed in this pull request
Previously we were using the
fastapi
Depends
to handle dependency injection for the ml model, but this loads the model on every function call.We could not switch to
fastapi
'slifetime
because this is incompatible withfaststream
.By reverting to pure
faststream
we can use its ownlifetime
which does work but this requires that we switch away from the http health check to a container healthcheckGuidance to review
Relevant links
depends on https://github.com/i-dot-ai/i-ai-core-infrastructure/pull/260
Things to check