-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plausible Code #428
Add Plausible Code #428
Conversation
…on in documents.py more succinct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one question about something minor.
@@ -147,11 +147,12 @@ | |||
CSP_DEFAULT_SRC = ( | |||
"'self'", | |||
"s3.amazonaws.com", | |||
"plausible.io", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this in DEFAULT as well as SCRIPT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just tried with out and it thew an CSP error
Context
Adds Plausible code to enable basic analytics tracking.
Changes proposed in this pull request
This introduces the code snippet with an if statement so we can separate analytics out per env
https://technologyprogramme.atlassian.net/browse/REDBOX-220?atlOrigin=eyJpIjoiYmI5MTU3ZmVmZmRkNGQ4MjkyZDg4NWZkOTE0N2M2M2UiLCJwIjoiaiJ9