Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plausible Code #428

Merged
merged 5 commits into from
May 22, 2024
Merged

Add Plausible Code #428

merged 5 commits into from
May 22, 2024

Conversation

Samuel-Hoskin
Copy link
Collaborator

@Samuel-Hoskin Samuel-Hoskin commented May 21, 2024

Context

Adds Plausible code to enable basic analytics tracking.

Changes proposed in this pull request

This introduces the code snippet with an if statement so we can separate analytics out per env

https://technologyprogramme.atlassian.net/browse/REDBOX-220?atlOrigin=eyJpIjoiYmI5MTU3ZmVmZmRkNGQ4MjkyZDg4NWZkOTE0N2M2M2UiLCJwIjoiaiJ9

@Samuel-Hoskin Samuel-Hoskin requested a review from 252afh May 21, 2024 12:22
Copy link
Contributor

@KevinEtchells KevinEtchells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one question about something minor.

@@ -147,11 +147,12 @@
CSP_DEFAULT_SRC = (
"'self'",
"s3.amazonaws.com",
"plausible.io",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this in DEFAULT as well as SCRIPT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just tried with out and it thew an CSP error

@Samuel-Hoskin Samuel-Hoskin merged commit 2574d7c into main May 22, 2024
9 checks passed
@Samuel-Hoskin Samuel-Hoskin deleted the feature/analytics branch May 22, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants