Update file expiry with RAG chat #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252afh
reviewed
May 22, 2024
| assert ( | ||
| ChatMessage.objects.get(chat_history__id=session_id, role=ChatRoleEnum.ai).source_files.first() == uploaded_file | ||
| ) | ||
| assert initial_file_expiry_date != File.objects.get(core_file_uuid=uploaded_file.core_file_uuid).expiry_date |
There was a problem hiding this comment.
Could we make this more utilitarian by adding a last_used date, so it can be used for more than expiry?
There was a problem hiding this comment.
Yeah, good idea :)
rachaelcodes
force-pushed
the
feature/REDBOX-234-update-file-expiry-on-rag
branch
from
fe330be to
1ff6288
Compare
252afh
approved these changes
May 22, 2024
|
|
||
| def __str__(self) -> str: # pragma: no cover | ||
| return f"{self.original_file_name} {self.user}" | ||
|
|
||
| def save(self, *args, **kwargs): | ||
| if not self.expiry_date: | ||
| if not self.last_referenced: |
There was a problem hiding this comment.
I wonder if we need this part if we have the migration? (or vice versa)
rachaelcodes
force-pushed
the
feature/REDBOX-234-update-file-expiry-on-rag
branch
from
1ff6288 to
eeeb8ad
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-234-update-file-expiry-on-rag
branch
from
eeeb8ad to
ce22eb9
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-234-update-file-expiry-on-rag
branch
from
ce22eb9 to
929d927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
File expiry dates are set on file creation (since #425 ), but should be updated to give another 30 days before expiry whenever they are quoted in a RAG chat.
Changes proposed in this pull request
On a call to
/post-message, the returned source files each have their expiry date extended for another 30 days (or as long into the future as configured with env vars).Guidance to review
Could use Django shell to inspect a file expiry date before and after it is used in a RAG chat.
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-234
Things to check
[ ] I have added any new ENV vars in all deployed environments[ ] I have run integration tests