Feature/redbox 234 keep deleted file django reference #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth merging main in again and running |
rachaelcodes
force-pushed
the
feature/REDBOX-234-keep-deleted-file-django-reference
branch
from
763a569 to
3281f36
Compare
rachaelcodes
force-pushed
the
feature/REDBOX-234-keep-deleted-file-django-reference
branch
from
3281f36 to
9b5aa15
Compare
rachaelcodes
deleted the
feature/REDBOX-234-keep-deleted-file-django-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After discussion with the wider product team about managing deleted documents, we decided to keep a reference to files in the Django database when the files were deleted from S3 and the core_api.
Changes proposed in this pull request
Now when a user chooses to delete an object, we delete the file from S3 rather than the whole Django object.
This also updates the UI with an interim version to show that the file is in a 'deleted' state.
Guidance to review
Run locally, including the database migrations (check nothing broken) - you might need to
make reset-dbbefore switching to a different branch. Try deleting a file and check how it displays - see if it deleted in minio.Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-234
Things to check
[ ] I have added any new ENV vars in all deployed environments[ ] I have run integration tests