Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix many type errors #464

Merged
merged 7 commits into from
May 28, 2024
Merged

Fix many type errors #464

merged 7 commits into from
May 28, 2024

Conversation

brunns
Copy link
Contributor

@brunns brunns commented May 28, 2024

Context

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

wpfl-dbt
wpfl-dbt reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor challenges

redbox/llm/llm_base.py Show resolved Hide resolved
redbox/models/errors.py Outdated Show resolved Hide resolved
redbox/models/settings.py Show resolved Hide resolved
redbox/parsing/chunkers.py Show resolved Hide resolved
redbox/storage/elasticsearch.py Outdated Show resolved Hide resolved
worker/src/app.py Outdated Show resolved Hide resolved
@wpfl-dbt
Copy link
Collaborator

Pretty sure this function is dead code and would error if run in prod as those s3 env vars are only set in local. Confirm with a search for redbox_core.client and note that CoreApiClient is the only thing imported from this script, and it doesn't use this function.

wpfl-dbt
wpfl-dbt approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

@brunns brunns merged commit d69bdd1 into main May 28, 2024
7 of 8 checks passed
@brunns brunns deleted the bugfix/many-type-errors branch May 28, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpfl-dbt wpfl-dbt wpfl-dbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunns @wpfl-dbt