Run e2e in cd pipeline #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunns
force-pushed
the
feature/run-e2e-in-cd-pipeline
branch
from
d8b15a8 to
66ef2be
Compare
brunns
force-pushed
the
feature/run-e2e-in-cd-pipeline
branch
from
e450a51 to
0205488
Compare
brunns
force-pushed
the
feature/run-e2e-in-cd-pipeline
branch
from
bc0b512 to
215eca4
Compare
brunns
force-pushed
the
feature/run-e2e-in-cd-pipeline
branch
from
2b2067f to
5ffe539
Compare
This reverts commit a72dd41.
brunns
force-pushed
the
feature/run-e2e-in-cd-pipeline
branch
from
e7533a0 to
5df61a9
Compare
gecBurton
approved these changes
Jun 4, 2024
.github/workflows/integration.yml
Outdated
| @@ -54,8 +54,7 @@ jobs: | |||
| cp .env.integration .env | |||
| echo AZURE_OPENAI_ENDPOINT=${{ secrets.AZURE_OPENAI_ENDPOINT }} >> .env | |||
| echo AZURE_OPENAI_API_KEY=${{ secrets.AZURE_OPENAI_API_KEY }} >> .env | |||
| docker compose up -d --wait elasticsearch | |||
| docker compose up -d --wait core-api worker | |||
| docker compose up -d --wait elasticsearch core-api worker db django_app | |||
There was a problem hiding this comment.
annoyingly we have found that the docker-compose depends_on is not sufficient to ensure that elastic is ready to accept connections, this leads to other services (especially the worker for some reason) failing to start, hence why elastic is started before all the others
.github/workflows/integration.yml
Outdated
| pip install boto3 | ||
| pip install python-jose | ||
| pip install websockets | ||
| poetry install --with dev |
django_app/redbox_app/settings.py
Outdated
| @@ -146,7 +144,7 @@ | |||
|
|
|||
| HOST = ( | |||
| "redbox.ai.cabinetoffice.gov.uk" | |||
| if ENVIRONMENT.lower() == "prod" | |||
| if ENVIRONMENT == "prod" | |||
There was a problem hiding this comment.
Suggested change
| if ENVIRONMENT == "prod" | |
| if ENVIRONMENT == "PROD" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
Guidance to review
Relevant links
Things to check