Delete expired files with management command #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunns
approved these changes
Jun 5, 2024
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("mock_datetime", "should_delete"), |
There was a problem hiding this comment.
Tiny nitpick - I wouldn't call this a mock really.
gecBurton
reviewed
Jun 5, 2024
|
|
||
| try: | ||
| core_api.delete_file(file.core_file_uuid, file.user) | ||
| file.delete_from_s3() |
There was a problem hiding this comment.
this could be part of the File.delete method 🤔 , probably doesnt add much and just over-complicates things?
There was a problem hiding this comment.
We currently have a File.delete that actually deletes the file, whereas this just removes the file contents but keeps a record of the File in Django (for auditing processes). I think this was a product decision a few weeks ago.
gecBurton
approved these changes
Jun 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that we have a way to track when files were last used, we can remove them with a management command. There is still some discussion about how this command will be triggered, and this might change over time.
There is a future change to come that will also remove expired Chats and ChatHistory.
Changes proposed in this pull request
Creates a management command that checks for files past their expiry date and removes their chunks from elastic storage, deleted the file contents from S3 and then transitions them to 'deleted' in Django (so we keep a record).
If there is an error in the elastic or S3 deletion, the file is marked as 'errored' in Django (a new status type). Errors are logged. We need to develop a process of reviewing and handling batches of errors.
Other changes
django_app/tests_playwright/pages.pyGuidance to review
Do you agree with the approach? Is there any other error handling needed? What else can we do around files that are partially deleted?
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-234
Things to check