Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created basic stuff document runnable creation function #539

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Jun 7, 2024

Context

We want to summarise but don't have the router to do it yet. This PR adds a basic stuff document runnable with unit tests that check basic functionality.

Changes proposed in this pull request

  • Add format.py and runnables.py as new files in the core API
  • Add our first runnable factory to it, make_stuff_document_runnable
  • Basic unit tests for this
  • A notebook to work on summarisation functions going forward

Guidance to review

  • Read the unit tests and check you're happy with what they do
  • Check the runnable function signature and check you're happy with how that works
  • Watch the unit tests pass, approve

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests -- ⚠️ End to end is fine, journey isn't -- suspect this branched from a pre-fix

@andy-symonds andy-symonds mentioned this pull request Jun 7, 2024
2 tasks
@wpfl-dbt wpfl-dbt marked this pull request as draft June 10, 2024 07:25
@wpfl-dbt
Copy link
Collaborator Author

Taking back to draft -- overcomplicated merging. Can do with Chunk, not LangChain objects

@wpfl-dbt wpfl-dbt marked this pull request as ready for review June 10, 2024 11:31
@wpfl-dbt
Copy link
Collaborator Author

Back to proper PR!

Copy link
Contributor

@andy-symonds andy-symonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, and we keep an eye on the integration tests - journey should be fixed from changes already merged to main.

@wpfl-dbt wpfl-dbt merged commit a366439 into main Jun 10, 2024
9 of 10 checks passed
@wpfl-dbt wpfl-dbt deleted the feature/summarisation-func branch June 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants