Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning RAG into a runnable function #554

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Turning RAG into a runnable function #554

merged 8 commits into from
Jun 12, 2024

Conversation

wpfl-dbt
Copy link
Collaborator

@wpfl-dbt wpfl-dbt commented Jun 11, 2024

Context

Testing, changing and swapping our chains is a nightmare. This splits a basic RAG chain out and adds tests to show it works. This lays better ground to improve and extend.

⚠️ Important details

  • I use a lower-level class for making the runnable that means we need to write Elastic queries ourselves
  • One reason is that I want to return Chunks, not Documents, and keep everything in our domain

Changes proposed in this pull request

  • Retriever runnable
  • RAG runnable
  • Tests for both

Guidance to review

  • Run the unit tests
  • Ensure you're happy with my decision to use a lower level class for retrieval

Things to check

@wpfl-dbt wpfl-dbt marked this pull request as ready for review June 11, 2024 13:44
George Burton and others added 2 commits June 12, 2024 13:33
* Working condense RAG runnable

* build fixed

* added missing fixture

* random addition to kick off build

* fixed fixture

---------

Co-authored-by: Will Langdale <[email protected]>
Co-authored-by: George Burton <[email protected]>
Co-authored-by: George Burton <[email protected]>
@wpfl-dbt wpfl-dbt merged commit 182b2de into main Jun 12, 2024
9 checks passed
@gecBurton gecBurton deleted the feature/rag-function branch July 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants