REDBOX 337 chat file selection #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e through the chat view.
brunns
commented
Jun 11, 2024
core_api/src/routes/chat.py
Outdated
| search_kwargs = {"filter": {"term": {"creator_user_uuid.keyword": str(user_uuid)}}} | ||
| search_kwargs = {"filter": {"bool": {"must": [{"term": {"creator_user_uuid.keyword": str(user_uuid)}}]}}} | ||
|
|
||
| if chat_request.selected_files is not None: |
There was a problem hiding this comment.
Suggested change
| if chat_request.selected_files is not None: | |
| if chat_request.selected_files: |
selected_files should never be None - the model uses a default factory.
brunns
commented
Jun 11, 2024
| @@ -15,6 +15,10 @@ class FileResource(admin.ModelAdmin): | |||
| list_display = ["original_file_name", "user", "status"] | |||
|
|
|||
|
|
|||
| class ChatMessageResource(admin.ModelAdmin): | |||
| list_display = ["chat_history", "text", "role"] | |||
There was a problem hiding this comment.
Suggested change
| list_display = ["chat_history", "text", "role"] | |
| list_display = ["chat_history", "text", "role", "created_at"] |
gecBurton
reviewed
Jun 11, 2024
| search_kwargs["filter"]["bool"]["should"] = [ | ||
| if chat_request.selected_files: | ||
| logging.info("chat_request.selected_files: %s", str(chat_request.selected_files)) | ||
| search_kwargs["filter"]["bool"]["must"] = [ |
added 2 commits
June 11, 2024 16:36
3 tasks
gecBurton
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
See https://technologyprogramme.atlassian.net/browse/REDBOX-337
This PR adds file_uuid param to core-api RAG endpoints, and update django to use them
Changes proposed in this pull request
Guidance to review
Relevant links
Things to check