Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REDBOX-337 - Tests for chat file selection #565

Merged
merged 13 commits into from
Jun 13, 2024

Conversation

brunns
Copy link
Contributor

@brunns brunns commented Jun 12, 2024

Context

Changes proposed in this pull request

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@brunns brunns marked this pull request as ready for review June 12, 2024 14:27
@brunns brunns marked this pull request as draft June 12, 2024 15:06
@brunns brunns marked this pull request as ready for review June 13, 2024 08:35
Copy link
Contributor

@KevinEtchells KevinEtchells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @brunns.
Wondering if it could do with a line or two in the README just to explain how to run locally / develop new tests?

@brunns brunns merged commit 36fb66c into main Jun 13, 2024
10 checks passed
@brunns brunns deleted the feature/REDBOX-337-tests-for-chat-file-selection branch June 13, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants