Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REST rag_chat endpoint to include the stuff summarisation already in streaming endpoint #584

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

andy-symonds
Copy link
Contributor

@andy-symonds andy-symonds commented Jun 14, 2024

Context

We want both the streaming endpoint point and REST endpoint to have the same functionality.

stuff_summarisation has recently been added to main using Langchain Expression Language (LCEL) runnables. This work adds the same stuff_summarisation functionality, using the same LCEL runnables to the REST rag_chat endpoint.

Changes proposed in this pull request

Updated REST rag_chat endpoint and added basic test to check the type of response when sent down the stuff_summarisation route.

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@andy-symonds andy-symonds marked this pull request as ready for review June 14, 2024 12:32
@andy-symonds andy-symonds force-pushed the rest-endpoint-stuff-summarisation-rebase-2 branch from 5ec0206 to c4279d0 Compare June 14, 2024 13:12
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn’t be that complicated but that’s not on you, it’s that we need to refactor the in-between bit so it return a more consistent object to turn into a response.

For the scope of the PR, I think this does the job nicely.

@andy-symonds andy-symonds merged commit 81c2678 into main Jun 14, 2024
6 checks passed
@andy-symonds andy-symonds deleted the rest-endpoint-stuff-summarisation-rebase-2 branch June 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants