Add Citations to Django app #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunns
force-pushed
the
revert-640-revert-564-feature/capture-chunks
branch
from
7aaf874 to
154ea96
Compare
rachaelcodes
force-pushed
the
revert-640-revert-564-feature/capture-chunks
branch
6 times, most recently
from
1229760 to
3628025
Compare
Move all database activity into @database_sync_to_async methods.
linting update migration numbers update poetry.lock
rachaelcodes
force-pushed
the
revert-640-revert-564-feature/capture-chunks
branch
from
3628025 to
a78d268
Compare
brunns
approved these changes
Jun 27, 2024
django_app/tests/test_migrations.py
Outdated
|
|
||
|
|
||
| @pytest.mark.django_db() | ||
| def test_0019_remove_chatmessage_source_files_textchunk_and_more(migrator): |
There was a problem hiding this comment.
World's tiniest nitpick.
Suggested change
| def test_0019_remove_chatmessage_source_files_textchunk_and_more(migrator): | |
| def test_0020_remove_chatmessage_source_files_textchunk_and_more(migrator): |
gecBurton
commented
Jun 27, 2024
| Citation.objects.create(chat_message=chat_message, file=file, text=doc.page_content) | ||
| if sources: | ||
| for file, citations in sources: | ||
| for citation in citations: |
There was a problem hiding this comment.
magic, good spot :)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Although the core-api returns citations, we don't currently record or store these in Django. It might be useful to do this for 2 reasons:
Changes proposed in this pull request
Citationmodel to the django appTo follow in a later PR
Guidance to review
Try some RAG chats locally; take a look in Django Admin for the Citation records.
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-367
Things to check