Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/updated docs and versions #645

Merged
merged 10 commits into from
Jun 25, 2024
Merged

Conversation

lmwilkigov
Copy link
Collaborator

Context

Versions weren't consistent and docs were broken

Changes proposed in this pull request

I've propagated updated version through pyproject.toml, library and core api. I've also spruced up the docs with a gif of the UI in action.

Guidance to review

Check out the status endpoint in core api and build the docs

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

pyproject.toml Outdated Show resolved Hide resolved
redbox/__init__.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we should think about a GH action to ensure that the version number is correct on release

@brunns
Copy link
Contributor

brunns commented Jun 25, 2024

LGTM

we should think about a GH action to ensure that the version number is correct on release

And also generate the changelog, assuming we think #638 is the right approach.

lmwilkigov and others added 2 commits June 25, 2024 09:22
Co-authored-by: Simon Brunning <[email protected]>
Co-authored-by: Simon Brunning <[email protected]>
Copy link
Contributor

@brunns brunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lmwilkigov lmwilkigov merged commit 5925519 into main Jun 25, 2024
5 checks passed
@lmwilkigov lmwilkigov deleted the feature/updated-docs-and-versions branch July 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants