Improve focus behaviour of chat messages and feedback #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachaelcodes
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A couple of improvements primarily for keyboard-only and screen-reader users
Changes proposed in this pull request
The feedback functionality is split into 4 sections. When a new section is shown, move focus to this new section. This means focus isn't "lost", and users can perceive where they are.
When a new message is being streamed, focus was moving to the container for the new message and feedback buttons. This is now just moving to the new message - which looks tidier for all users.
Guidance to review
Tabto go forwards.Shift+Tabto go backwards.Spaceto interact with control.