Feature/move to langgraph #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
| ): | ||
| """REST endpoint. Get a mapping of all tools available via chat.""" | ||
| return [{"name": name, "description": tool[1]} for (name, tool) in routable_chains.items()] | ||
| return [{"name": name, "description": description} for name, description in redbox.get_available_keywords().items()] | ||
|
|
||
|
|
||
| @chat_app.websocket("/rag") |
There was a problem hiding this comment.
gecBurton
reviewed
Jul 30, 2024
| @@ -1,3 +1,7 @@ | |||
| """Redbox is a Python library for working with the Redbox API, data and services.""" | |||
|
|
|||
| from redbox.app import Redbox | |||
|
|
|||
| __version__ = "0.3.0" | |||
There was a problem hiding this comment.
Suggested change
| __version__ = "0.3.0" | |
| __version__ = "0.5.0" |
gecBurton
reviewed
Jul 30, 2024
| parameterised_retriever: VectorStoreRetriever = None, | ||
| tokeniser: Encoding = None, | ||
| env: Settings = None, | ||
| debug: bool = False, |
There was a problem hiding this comment.
note-to-self: settings that define:
- llm
- all_chunks_retriever
- parameterised_retriever
- tokeniser
should be the settings that are injected into the request and not inenv = Settings
gecBurton
reviewed
Jul 30, 2024
| ) | ||
|
|
||
|
|
||
| def get_embeddings(env: Settings) -> Embeddings: |
There was a problem hiding this comment.
pleased to see this moved here and out of its own file
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
reviewed
Jul 30, 2024
gecBurton
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We should make use of the new Redbox class which is based on LangGraph to simplify the Redbox interface and create a library which is separate from the API to enable other uses and better experimentation
Changes proposed in this pull request
Create a simple class Redbox which wraps the Langgraph work. Use this object in core-api in place of the current runnables.
Replace the testing in core-api with the TestCases setup from redbox-core
Things to check