Bugfix/attempt to fix GitHub action notifications #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyburke1
reviewed
Jul 30, 2024
dannyburke1
reviewed
Jul 30, 2024
dannyburke1
reviewed
Jul 30, 2024
dannyburke1
reviewed
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
github actions currently always reports a successful build even if the main flow fails
withblocks so anything in a with block has been moved out of envsuccess()andfailure()also can't be evaluated in a with block, they pretty much only work well in a jobs if conditionChanges proposed in this pull request
Guidance to review
Manually run the _cicd.yml workflow
Relevant links
Things to check