Prevent accidental double-clicking of submit buttons #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
252afh
approved these changes
Aug 5, 2024
| let buttons = document.querySelectorAll(`[data-prevent-double-click="true"]`); | ||
| buttons.forEach((button) => { | ||
| button.addEventListener("click", () => { | ||
| window.setTimeout(() => { |
There was a problem hiding this comment.
Is the first timeout needed?
There was a problem hiding this comment.
Seemingly so. I first tried it without and it prevented anything from happening! Pushing it further down the queue seems to solve that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A fix for https://technologyprogramme.atlassian.net/browse/REDBOX-567?atlOrigin=eyJpIjoiNzQ1MzA4MGIwMjU4NGUzYjhlY2QxODVkYTUwMDU3NjYiLCJwIjoiaiJ9 and some associated tidy-ups.
Changes proposed in this pull request
govuk-buttonimportsGuidance to review
Things to check