Feature/add aisettings to django #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
reviewed
Aug 7, 2024
| @@ -219,6 +221,14 @@ def get_sources_with_files( | |||
| def file_save(file): | |||
| return file.save() | |||
|
|
|||
| @staticmethod | |||
| @database_sync_to_async | |||
| def get_ai_settings(user: User) -> AISettings: | |||
There was a problem hiding this comment.
this appears again in django_app/redbox_app/redbox_core/client.py ?
There was a problem hiding this comment.
Isn't one for streamed and one for non-streamed requests?
gecBurton
reviewed
Aug 7, 2024
| model_name="user", | ||
| name="ai_settings", | ||
| field=models.ForeignKey( | ||
| default="default", |
gecBurton
reviewed
Aug 7, 2024
| NewUser = new_state.apps.get_model("redbox_core", "User") # noqa: N806 | ||
|
|
||
| for user in NewUser.objects.all(): | ||
| assert user.ai_settings.label == "default" |
gecBurton
approved these changes
Aug 7, 2024
rachaelcodes
force-pushed
the
feature/add-aisettings-to-django
branch
from
b2b5171 to
ccae92c
Compare
rachaelcodes
force-pushed
the
feature/add-aisettings-to-django
branch
from
ccae92c to
e68cf0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After #894 AISettings can be sent to
core_apifrom Django as part of the chat request. This PR implements AISettings in Django.Changes proposed in this pull request
AISettingsmodel with the same defaults as are currently in redbox-core (these will later be removed and kept only in Django)AISettingslabelleddefaultthat is set as the default for all Django usersAISettingsto core-api as part of the chat payloadGuidance to review
Try running locally and creating your own AISettings in the Django shell.
Relevant links
https://technologyprogramme.atlassian.net/browse/REDBOX-593
Things to check