Clear up unit tests in redbox-core, add tests for loaders #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpfl-dbt
changed the title
lmwilkigov
approved these changes
Aug 28, 2024
gecBurton
reviewed
Aug 29, 2024
| @@ -1,6 +1,8 @@ | |||
| import pytest | |||
| from contextlib import nullcontext as does_not_raise | |||
| from uuid import uuid4 | |||
| from pytest_mock import MockerFixture | |||
gecBurton
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#964 removed async from ingestion. I did a spike on adding it back and decided not to (so this closes #986 ), but in the process wrote unit tests for loaders, and tidied up type hints for fixtures and tests in core.
Changes proposed in this pull request
Guidance to review
Things to check