Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to acorn 6 #112

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Upgrade to acorn 6 #112

merged 2 commits into from
Nov 29, 2018

Conversation

ctavan
Copy link
Contributor

@ctavan ctavan commented Nov 28, 2018

Currently a very old version of acorn-jsx is being used to parse occurences of the <Trans> component.

This leads to lots of errors when people use modern JavaScript syntax that cannot be parsed by the ancient acorn.

This patch upgrades to the latest acorn-jsx version and comes with a custom version of acorn-jsx-walk based on acorn-walk.

Should fix:

@coveralls
Copy link

coveralls commented Nov 28, 2018

Coverage Status

Coverage increased (+0.6%) to 91.463% when pulling 0424c5e on contentpass:upgrade-to-acorn-6 into 60be465 on i18next:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 89.634% when pulling 58a5df2 on contentpass:upgrade-to-acorn-6 into 60be465 on i18next:master.

@cheton cheton merged commit 4bfa988 into i18next:master Nov 29, 2018
@cheton
Copy link
Member

cheton commented Nov 29, 2018

@ctavan This definitely helps address these issues. Thank you.

@ctavan ctavan deleted the upgrade-to-acorn-6 branch November 29, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants